Hi
SELINUX used to be one of the checks that the FreePBX install script did before allowing installation, if it was not disabled then FreePBX would not install.
Additionally, this is a script that makes an existing copy of CentOS look like it has been installed by the PiaF ISO so that the checks that the piafdl installer does are passed and the install continues.
The scripts job is not to make improvements or changes to the the system. From ks.cfg on the PiaF iso, we see that SELINUX is set to disabled, as they have set this, so must this script.
Therefore, I would suggest you address your concerns about switching off SELinux to the PiaF development team.
The issue with using the yum install packages from ks.cfg against the CentOS repository is that it will install ALL of the packages in the yum group that exist in the CentOS repository, however when group install is run as part of the ISO install, it will only install those packages that are on the ISO.
So I would argue that your approach installs more "stuff"
So to get the list of packages installed, I simply install the PBX in a Flash ISO, and then exit out of the installation on the first screen, then yum list installed. This gives me an precise list of exactly what was installed by the PiaF ISO with no extras.
Setting the hardware clock just saved me a lot of trouble, where the clock is set incorrectly, some tarballs don't extract, and Zap / Dahdi does not install.
I do not set the TZ because I imagined that it had been done during the initial install of CentOS, although I realise that if you are working with VM's this may not be applicable.
In terms of the -y on line 131, for the moment, I will leave the user to interact with the script but may add it in a future release.
Thank you for your comments.
Yours
Joe